Skip to content

Fix/pcp compat fixes #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: release1181
Choose a base branch
from
Open

Fix/pcp compat fixes #1002

wants to merge 21 commits into from

Conversation

tw2113
Copy link
Member

@tw2113 tw2113 commented Aug 27, 2025

This PR handles changes and recommendations provided by https://wordpress.org/plugins/plugin-check/

  1. Extra escaping of our output where applicable in various areas.
  2. Lack of need for language pack loading.
  3. Translator placeholder notes
  4. Mismatched textdomains

tw2113 added 21 commits July 30, 2025 15:26
@tw2113
only need major versions as per developer.wordpress.org
2ff81fd
@tw2113
fix missed textdomains for WPGraphQL integration
3a5213e
@tw2113
we verify nonces elsewhere before we access this
01b8672
@tw2113
if check for description
d7c6fe2
@tw2113
ignore this line
18d21fa
@tw2113
textdomains even if we do not distribute these
0f69478
@tw2113
translator messages
88f690c
@tw2113
this function has been discouraged since 4.6, removing
44fdcdf
@tw2113
specifying this is not needed
37f5f34
@tw2113
mass translators messaging
ae1c30a
@tw2113
make use of unslash
8492de8
@tw2113
escape some variables
fc1baa7
@tw2113
these functions do not return anything, so nothing to echo. they do e…
93053b7 
…cho to the browser themselves+output buffering
@tw2113
attribute escaping for spots that end up with variables
1089097
@tw2113
move description setting to a dedicated function with nonce checks to…
c0e1695 
… handle reported security issues
@tw2113
Merge branch 'fix/999-post-global-edits' into fix/pcp-compat-fixes
9562edd
@tw2113
add escaping to all our tools/get code output
2a79a39
@tw2113
php ignore already escaped content
8d39fb4
@tw2113
match up echo status for post types
d75a2ae
@tw2113
one last escape for echo
9e9b7b2
@tw2113
add escaping to all our tools/get code output
c0cb47c
@tw2113 tw2113 requested a review from ramiwds August 27, 2025 17:45
@tw2113 tw2113 changed the base branch from master to release1181 August 27, 2025 17:45
@tw2113 tw2113 mentioned this pull request Aug 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiwds ramiwds Awaiting requested review from ramiwds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tw2113