Fixed duplexMerge page issue #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the bugfixing pull request. It seems that the fix is related to issue #24, is that correct? |
|
@KreutzerCode any chance of pulling this one in? |
|
@AdrianBav I would love to do that. I'm still waiting for my pull request to be checked. But I am not the maintainer of the Project. @Webklex can you indicate if you are still accepting pull requests for this repository? |
|
@Webklex Any chance you can merge this PR? Forking the repo and applying this fix was the only way to make duplexMerge work. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #24
Error: Cannot access protected property setasign\Fpdi\Fpdi::$page
if ($duplexSafe && $oFPDI->page % 2)Fix: changing line 249 in PDFMerger
if ($duplexSafe && $oFPDI->PageNo() % 2)