This repository was archived by the owner on Jul 15, 2019. It is now read-only.
sherpa without sherpa. #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maditya
reviewed
Apr 24, 2017
httpfront/httpfront.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| fmt.Printf("lookup: %v\n", lr); |
maditya
reviewed
Apr 24, 2017
lookup.go
Outdated
| return nil, nil | ||
| } else { | ||
| if pf.Entry == nil || pf.Profile == nil { | ||
| return nil, nil // empty entry or profile |
Contributor
There was a problem hiding this comment.
shouldn't this return an error?
maditya
reviewed
Apr 24, 2017
lookup.go
Outdated
| return n.value | ||
| } | ||
|
|
||
| // getUpdate returns the last update to profile of idx during or before epoch. |
maditya
reviewed
Apr 24, 2017
proto/AuthorizationPolicypr_test.go
Outdated
| import ( | ||
| github_com_gogo_protobuf_jsonpb "github.com/maditya/protobuf/jsonpb" | ||
| github_com_gogo_protobuf_proto "github.com/maditya/protobuf/proto" | ||
| github_com_gogo_protobuf_jsonpb "github.com/maditya/protobuf/jsonpb" |
Contributor
There was a problem hiding this comment.
shouldn't this point to gogo/protobuf ?
Author
There was a problem hiding this comment.
Can I remove generated files? It's confusing.
added 5 commits
April 26, 2017 15:20
skip tests that invole GoString() and String() because non deterministic iteration of map.
maditya
reviewed
May 3, 2017
| // as specified in https://github.com/yahoo/coname/blob/master/proto/client.proto#L63-L89 | ||
| type lp struct { | ||
| Entry string `json:"entry"` | ||
| Entry json.RawMessage `json:"entry"` |
Contributor
There was a problem hiding this comment.
why did we have to change this?
Author
There was a problem hiding this comment.
because it's not a struct, not a string.
maditya
reviewed
May 3, 2017
proto/generate.sh
Outdated
| print($0) | ||
| }' < client.pb.go > client.pb.go.tmp && mv client.pb.go.tmp client.pb.go | ||
|
|
||
| for i in *.pb.go; do sed "s/\(NewPopulatedEncoded[A-Za-z_0-1]*\)(\(.*\))/\1(\2, easy)/" < $i > $i...; mv -f $i... $i; done |
Contributor
There was a problem hiding this comment.
can you add a comment on what this is trying to do?
maditya
reviewed
May 3, 2017
proto/replication.proto
Outdated
|
|
||
| message EpochUpdate { | ||
| EpochDelimiter delimiter = 1; | ||
| bool update = 2; |
Contributor
There was a problem hiding this comment.
can you add a comment on the purpose of this field?
maditya
reviewed
May 3, 2017
proto/replication.proto
Outdated
| message EpochUpdate { | ||
| EpochDelimiter delimiter = 1; | ||
| bool update = 2; | ||
| fixed64 UID = 3; |
Contributor
There was a problem hiding this comment.
can you add a comment on the purpose of this field?
added 13 commits
May 4, 2017 18:24
skip the timestamp test.
fix the commitment bug.
…ishiguro-sherpa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.