Made the default to display crates having only array-index-accesses #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added env option to disable and get back previous behaviour of suppressing only-array-index-access crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior
Panic-Analyzer would previously hide crates that only have array-access audit triggers and no other audit triggers.
Why the change
As we want to see all audit triggers for possible panics, suppressing crates with only array-access audit triggers as a default is surprising and counter-intuitive for us.
What this does
Made it default, that panic-analyzer would display all audit triggers, even if the crate only has array-access audit triggers.
Added an environment variable to restore previous behavior and hide crates that have only array-audit triggers again.
Ultimately making the default of panic-analyzer the most restrictive setting possible.