Make GUI able to compile on both Qt5 and Qt6 #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing same thing as #1514, there are deprecation warnings (currently disabled in cmake file) on Qt6 so author or #1514 may address this in future PR, but that does not affect functionality.
QtPropertyBrowser is also update for MCY gui, so this is now using same code base now (on qt6 branch there now).
Main concern is addressed and that is that application is able to work on both Qt5 and Qt6 without change, and also on Wayland there was a crash that is now fixed.
We can change instructions and CI if we would like people to switch to Qt6, but it should work same on both environments.