Skip to content

fix: getReservesHumanized numeric overflow #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: getReservesHumanized numeric overflow #631

wants to merge 2 commits into from

Conversation

@HarshitJoshi
Copy link

@HarshitJoshi HarshitJoshi commented Jun 23, 2025 •
edited
Loading

  • Represent debtCeilingDecimals as string type in getReservesHumanized to avoid numeric overflow
  • Add test case for numeric overflow scenario
  • Fix tests by removing unused BigNumber declaration in math-utils

Resolves #620 #621

@HarshitJoshi
fix: prevent numeric overflow in getReservesHumanized
90b19b3 
- represent debtCeilingDecimals as string in getReservesHumanized to avoid numeric overflow
- add test case for numeric overflow scenario
@HarshitJoshi
fix: test
7e516e1
@sheinix
Copy link

sheinix commented Jul 9, 2025

gm
just facing this issue atm, any idea of eta for next release to include this one? thanks! :r🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UiPoolDataProvider.getReservesHumanized: numeric overflow

2 participants

@HarshitJoshi @sheinix