Skip to content

Conversation

AGMASO
Copy link
Collaborator

@AGMASO AGMASO commented Oct 3, 2025

General Changes

  • Refactored reserve-overview to use the aave-sdk.
  • We’re using the SDK across this page except for the Action modals. Refactoring those would require deeper changes to ModalWrapper, which would impact other modals not present on this page.

Developer Notes

  • This version isn’t 100% complete. We’re still missing a few fields that aren’t exposed by the SDK:

    1. interestRateStrategyAddress (ALREADY ADDED)
    2. Correct values for isolationModeConfig.debtCeiling.amount and isolationModeConfig.totalBorrows.usd (STILL WAITING FOR BACKEND UPDATE)
    3. reserve.unbacked and reserve.unbackedUSD are not available in the SDK (we don't need that? not exposed on Sdk)
    4. The token icon for vToken currently falls back to default. I’ve changed it to display as waToken for now—Is that acceptable, or should we create a dedicated overlay for vTokens?

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface Ready Ready Preview Comment Oct 13, 2025 7:45am

@AGMASO AGMASO changed the base branch from main to refactor/sdk-in-markets October 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant