Skip to content

Conversation

UshakovMikhail
Copy link

Changed our median and percentile functions with numpy ones. Changed check_dirpath function and added unittests for it

…check_dirpath function and added unittests for it
@alexeigurevich
Copy link
Contributor

Seems OK to me!
But I think we should not merge it into master right now since we yet want to release master as Quast v.5.1.0 with Python2 compatibility.
What about fork quast-ng or quast-6 branch from master and merging Misha's step-by-step changes there? @almiheenko what do you think?

Copy link
Contributor

@alexeigurevich alexeigurevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK!

@alexeigurevich alexeigurevich self-requested a review October 25, 2021 15:14
@UshakovMikhail UshakovMikhail changed the base branch from master to new-master November 9, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants