Skip to content

11. Winning PR!! Congratulations :) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

11. Winning PR!! Congratulations :) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/main/java/sk/ableneo/openslava2023/codefix/BalloonChallenge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,26 @@

import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;

// TODO: fix the class
public class BalloonChallenge {

public LinkedList findOrdersForProduct(Product p, boolean debug) {
ArrayList l = new ArrayList();
ArrayList list = getAllOrders();
for (int i = 0; i < list.size(); i++) {
Order order = (Order) list.get(i);
boolean found = false;
if (order.getProducts().size() > 0) {
for (int j = 0; j <= order.getProducts().size(); j++) {
Product p2 = (Product) order.getProducts().get(j);
found = (p2 == p);
public List<Order> findOrdersForProduct(Product p, boolean debug) {
List<Order> res = new ArrayList<>();
List<Order> orders = getAllOrders();
for_order: for (Order order : orders) {
List<Product> ps = order.getProducts();
if (ps == null)
continue;
for (Product p2 : ps) {
if (p2.equals(p)) {
res.add(order);
continue for_order;
}
if (found && order != null)
l.add(order);
}
}
return new LinkedList(l);
return res;
}

public ArrayList getAllOrders() {
Expand Down