Skip to content

Conversation

ktor
Copy link
Member

@ktor ktor commented Jul 4, 2025

No description provided.

@ktor ktor requested a review from Copilot July 4, 2025 12:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for importing DDM structures from JSON-exported definitions and wires in the necessary DataDefinition REST resource.

  • SetupArticles.addDDMStructure now uses DataDefinition.toDTO + DataDefinitionResource instead of the old DDMUtil approach
  • Introduces ServiceTrackerBuilder helper for obtaining OSGi service factories
  • Updates pom.xml to shade in DataDefinitionUtil and bumps Prettier/Java compiler versions
  • Cleans up formatting in multiple util classes and adjusts README with the new version

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.

File Description
src/main/java/.../SetupArticles.java Switches JSON parsing to REST DTO + DataDefinitionResource
src/main/java/.../ServiceTrackerBuilder.java Provides OSGi service tracker for factory lookup
pom.xml Adds maven-shade to include DataDefinitionUtil, updates plugins
README.adoc Increments version and notes added JSON import support
Comments suppressed due to low confidence (3)

src/main/java/com/ableneo/liferay/portal/setup/core/SetupArticles.java:134

  • New logic branch for creating and populating a DDMStructure via the DataDefinitionResource is introduced here; consider adding unit or integration tests to cover the JSON import path.
                addDDMStructure(structure, groupId, classNameId);

src/main/java/com/ableneo/liferay/portal/setup/core/util/ServiceTrackerBuilder.java:3

  • [nitpick] Public class ServiceTrackerBuilder lacks JavaDoc. Adding a brief description of its purpose and usage would improve maintainability.
import com.ableneo.liferay.portal.setup.SetupConfigurationThreadLocal;

Copy link

@ktor ktor self-assigned this Jul 10, 2025
@ktor ktor merged commit 65d4162 into ableneo:master Jul 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant