Skip to content

more than one record type does not have common attr and it's ok #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

more than one record type does not have common attr and it's ok #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/memlat/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ func parsePerf(fileName string) *database {
}
}

if err := rs.Err(); err != nil {
fmt.Printf("error while reading record: %s\n", err)
os.Exit(1)
}

if numSamples == 0 {
fmt.Printf("no memory latency samples in %s (did you use \"perf mem record\"?)\n", fileName)
os.Exit(1)
Expand Down
11 changes: 9 additions & 2 deletions perffile/records.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,18 @@ func (r *Records) Next() bool {

// Parse common sample_id fields
if r.f.sampleIDAll && hdr.Type != RecordTypeSample && hdr.Type < recordTypeUserStart {
// mmap records in the prologue don't have eventAttrs
// some records in the prologue don't have eventAttrs
// in recent perf versions, but that's okay.
//
// TODO: When is perf okay with missing eventAttrs?
r.parseCommon(bd, &common, hdr.Type == RecordTypeMmap)
missingOk := (hdr.Type == RecordTypeMmap) ||
(hdr.Type == RecordTypeFork) ||
(hdr.Type == RecordTypeComm) ||
(hdr.Type == recordTypeMmap2)
r.parseCommon(bd, &common, missingOk)
if r.err != nil {
return false
}
}

// Parse record
Expand Down