Skip to content

Conversation

andrei-shershukov
Copy link

This change enchants the Workflow Pod readiness check by ensuring the proper phase and state of the Pod. This check is running during the runContainerStep. This enables us to run status and readiness probe checks of the containers before executing the workflow job, ensuring the true readiness of the running containers and removing potential issues. It will also allow users to run scripts before the workflow job begins, such as running a DinD sidecar container and waiting for it to launch the daemon via the startup or readiness container probes.

@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 11:19
@andrei-shershukov andrei-shershukov requested a review from a team as a code owner October 10, 2025 11:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhances the Workflow Pod readiness check by implementing a more comprehensive state validation system that checks both pod phases and conditions before executing workflow jobs.

  • Introduces PodCondition enum with comprehensive pod condition types
  • Adds new waitForPodState and waitForPodToBeReady functions for enhanced readiness validation
  • Replaces basic phase-only checking with combined phase and condition validation in runContainerStep

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/k8s/src/k8s/utils.ts Adds PodCondition enum defining Kubernetes pod condition types
packages/k8s/src/k8s/index.ts Implements enhanced pod state checking functions with condition validation
packages/k8s/src/hooks/run-container-step.ts Updates container step execution to use improved readiness check

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant