#226: Added a better Workflow Pod readiness check #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enchants the Workflow Pod readiness check by ensuring the proper phase and state of the Pod. This check is running during the
runContainerStep
. This enables us to run status and readiness probe checks of the containers before executing the workflow job, ensuring the true readiness of the running containers and removing potential issues. It will also allow users to run scripts before the workflow job begins, such as running a DinD sidecar container and waiting for it to launch the daemon via the startup or readiness container probes.