-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add uri typed headers #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add uri typed headers #3455
Conversation
c75c46d to
3d17c3f
Compare
3d17c3f to
f96a21f
Compare
|
@robjtede those changes have been made. Let me know if you have any more feedback. |
|
I'm still interested in this patch, if you think it's worth merging in. |
|
Just come back to this and I still like it, but I'm going to make the I'll cut a release with what's been merged already and get to this one afterwards. Should be easy to fixup and get out this weekend. |
|
Run into a hurdle with that idea, that |
PR Type
Feature
PR Checklist
Overview
This adds the
Location,Content-LocationandReferertyped headers. It also adds theTryIntoHeaderValuetrait forUriwhich allowsUrito be a typed value for these headers.While
Locationtechnically is a different type thanContent-LocationandReferer(Locationallows for protocol relative URIs) I think it's not a large enough distinction to warrant a separate type, as using protocol relative urls is quite rare. However we could useurl::Urlinstead ofUriforLocationif we wanted to allow for that distinction.The motivation for this PR is to allow for using
Refereras an Extractor, and the other two were easy enough to also add, and complete the trifecta of URI related headers (to the best of my knowledge).