Adding Omnimo-nRF52840 board #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Jun 30, 2025
| //--------------------------------------------------------------------+ | ||
|
|
||
| //Shared VID/PID with pca10056 | ||
| #define USB_DESC_VID 0x1209 |
There was a problem hiding this comment.
could you provide link/proof to where this vid/pid is allocated to this board.
|
Here is the link
https://pid.codes/1209/CECE/
…On Mon, Jun 30, 2025 at 4:57 AM Ha Thach ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/boards/omnimo_nrf52840/board.h
<#347 (comment)>
:
> +#define BUTTON_1 _PINNUM(1, 02)
+#define BUTTON_2 _PINNUM(1, 07)
+#define BUTTON_PULL NRF_GPIO_PIN_PULLUP
+
+//--------------------------------------------------------------------+
+// BLE OTA
+//--------------------------------------------------------------------+
+#define BLEDIS_MANUFACTURER "eAFAQ"
+#define BLEDIS_MODEL "OMNIMO nRF52840"
+
+//--------------------------------------------------------------------+
+// USB
+//--------------------------------------------------------------------+
+
+//Shared VID/PID with pca10056
+#define USB_DESC_VID 0x1209
could you provide link/proof to where this vid/pid is allocated to this
board.
—
Reply to this email directly, view it on GitHub
<#347 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOZY54GGPQNK276R3SYOTYL3GCYRNAVCNFSM6AAAAABXHSJRP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRZHAZDIMRXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnimo-nRF52840 (https://www.crowdsupply.com/eafaq/omnimo-nrf52840) is a compact, all-in-one, and easy-to-use development board that support several types of add-on modules.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsThis checklist items that are not applicable to your PR can be deleted.
Description of Change
Please describe your proposed Pull Request and it's impact.