-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added mono to stereo conversion and panning to audiomixer.Mixer
#10529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like a few atmel-samd boards are running out of flash firmware space. Would it be better for me to disable this feature (panning and mono-to-stereo) on those boards or disable a larger existing feature? The following boards are affected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me. I have not yet tested it on hardware. Not sure offhand how to free up a few bytes, it isn't overflowing by much. I'll leave that to others who may know more about it.
56f531f
to
7b5587c
Compare
@dhalbert Apologies if my branch sync messed something up, but it looks like all checks are clear now. Thank you for your work on those boards. Let me know if there's anything else I can help with to get this over the finish line. 👍 |
@relic-se Nothing wrong! I just shrunk some boards and will now merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
shrink overflowing boards after #10529
Allow mono audiosample sources to play through a stereo
audiomixer.Mixer
object and addaudiomixer.MixerVoice.panning
(withsynthio.BlockInput
support).These new features greatly improve
audiomixer.Mixer
usability for sample-based musical instruments. It also optimizes flash storage when stereo audio files are unnecessary when mixed with a stereo source (you'd otherwise have to double the channel count + file size).Code Demonstration (requires appropriate mono.wav and stereo.wav files):
Closes #4463