Skip to content

Support SingleColumnValueFilter and StringComparator #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support SingleColumnValueFilter and StringComparator #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions lib/hbase-scanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,25 @@ Scanner.prototype.create = function(params,callback){
}
}
if(params.filter){
var fieldsToEncode = {
value: { // generic, used for many filters
exceptions: {
RegexStringComparator: true,
PageFilter: true,
SubstringComparator: true
}
},
family: {}, // SingleColumnValueFilter to specify what column to search
qualifier: {}, // SingleColumnValueFilter to specify what column to search
};
var encode = function(obj){
for(var k in obj){
if(k === 'value' && (!obj['type'] || obj['type'] !== 'RegexStringComparator' && obj['type'] !== 'PageFilter')){
obj[k] = utils.base64.encode(obj[k]);
var field = fieldsToEncode[k];
if(field) {
var exceptions = field.exceptions;
if (!exceptions || !obj['type'] || !exceptions[obj['type']]) {
obj[k] = utils.base64.encode(obj[k]);
}
}else if(typeof obj[k] === 'object'){
encode(obj[k]);
}
Expand Down Expand Up @@ -102,4 +117,4 @@ Scanner.prototype.get = function(callback){
});
};

module.exports = Scanner;
module.exports = Scanner;
18 changes: 18 additions & 0 deletions test/testFilter.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,3 +161,21 @@ module.exports =
assert.strictEqual('test_filter|row_2', cells[0].key)
assert.strictEqual('node_column_family:bb', cells[0].column)
this.delete next
'SingleColumnValueFilter # op equal substringcomparator': (next) ->
utils.getClient (error, client) ->
client
.getScanner('node_table')
.create
startRow: 'test_filter|row_1'
endRow: 'test_filter|row_4'
maxVersions: 1
filter: {"family":"node_column_family","qualifier":"aa","op":"EQUAL","type":"SingleColumnValueFilter","comparator":{"value":"ab","type":"SubstringComparator"}}
, (error,id) ->
assert.ifError error
this.get (error,cells) ->
assert.ifError error
assert.strictEqual(3,cells.length)
assert.strictEqual('test_filter|row_1', cells[0].key)
assert.strictEqual('test_filter|row_1', cells[1].key)
assert.strictEqual('test_filter|row_1', cells[2].key)
this.delete next