Add support for making MITMing selective depending on peer host/port #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is helpful when needing to deal with certificate pinned applications at the same time as the intended MITMable traffic, when both must use the same proxy.
|
The travis ci build for java 8 failed for this pull request, but succeeded in my repository (https://travis-ci.org/ScottDennison/LittleProxy/jobs/350944465), I'm not knowledgeable enough with travis ci to know why. The travis ci build for java 7 fails in master already, and is also fixed by #402. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when needing to deal with certificate pinned applications at the same time as the intended MITMable traffic, when both must use the same proxy.
Note: This pull request should be rejected if pull request #402 is merged first. #402 upgrades the java version of this project to 8, at which point it would be better to make shouldMITMPeer a default method inside MitmManager instead of in the extension interface SelectiveMitmManager.