Skip to content

Conversation

mahdipub
Copy link

It helps improve Ant-Contrib role by replacing wget with get_url module. Also when extracing, on macos the unarchive module might fails as it asks for gtar but default macos tar is bsdtar. The workaround is to run it as command on macos machines.

Signed-off-by: [email protected]

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@karianna
Copy link
Contributor

@mahdipub linter failures

@sxa
Copy link
Member

sxa commented Sep 30, 2024

Given the comment above the line, This needs to be tested on Solaris before it can be approved.
VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

@mahdipub mahdipub force-pushed the ant_contrib_role_improvement branch from 45d9d88 to dd6d373 Compare September 30, 2024 17:14
@mahdipub
Copy link
Author

@mahdipub linter failures

Thanks, that's resolved.

@karianna
Copy link
Contributor

karianna commented Oct 1, 2024

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

Don't see Solaris as part of that run?

@sxa
Copy link
Member

sxa commented Nov 28, 2024

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

Don't see Solaris as part of that run?

😕 Solaris10 is in there and green

image

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the runs failed but solaris passed.

@sxa
Copy link
Member

sxa commented Dec 3, 2024

Tagging in @gdams for a review since he put in the use of wget for Solaris as part of #1585 but maybe the underlying problem was resolved in more recent versions of ansible

@sxa sxa requested a review from gdams December 3, 2024 13:25
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit of a change to be moving from wget to an ansible module but also switching from unarchive to a custom command on macos. Can you clarify where you've seen an error with this, as I don't think it's been a problem for us in our playbook executions.
Would be good to remove the ? but on the URL before putting this in as it's unnecessary.

@sxa
Copy link
Member

sxa commented Sep 2, 2025

@sxa
Copy link
Member

sxa commented Sep 2, 2025

New VPC run: https://ci.adoptium.net/job/VagrantPlaybookCheck/2149/

@mahdipub Assuming you still want to get this in, can you rebase your changes on top of master as there's some fixes we need in there to be able to run these checks

@mahdipub mahdipub force-pushed the ant_contrib_role_improvement branch from 0aaba80 to 6eaf978 Compare September 2, 2025 14:44
It helps improve `Ant-Contrib` role by replacing wget with get_url module. Also when extracting, on macos the `unarchive` module might fails as it asks for gtar but default macos tar is `bsdtar`. The workaround is to run it as command on macos machines.

Signed-off-by: [email protected]
@mahdipub mahdipub force-pushed the ant_contrib_role_improvement branch from 6eaf978 to c7f3aec Compare September 2, 2025 14:46
@mahdipub
Copy link
Author

mahdipub commented Sep 2, 2025

@sxa that is done.

@sxa
Copy link
Member

sxa commented Sep 2, 2025

Running another VPC at https://ci.adoptium.net/job/VagrantPlaybookCheck/2150/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants