-
-
Notifications
You must be signed in to change notification settings - Fork 100
unixPB: improves Ant-Contrib
role compatibility
#3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mahdipub linter failures |
Given the comment above the line, This needs to be tested on Solaris before it can be approved. |
45d9d88
to
dd6d373
Compare
Thanks, that's resolved. |
Don't see Solaris as part of that run? |
😕 Solaris10 is in there and green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the runs failed but solaris passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit of a change to be moving from wget
to an ansible module but also switching from unarchive
to a custom command on macos. Can you clarify where you've seen an error with this, as I don't think it's been a problem for us in our playbook executions.
Would be good to remove the ?
but on the URL before putting this in as it's unnecessary.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Ant-Contrib/tasks/main.yml
Outdated
Show resolved
Hide resolved
@mahdipub Assuming you still want to get this in, can you rebase your changes on top of master as there's some fixes we need in there to be able to run these checks |
0aaba80
to
6eaf978
Compare
It helps improve `Ant-Contrib` role by replacing wget with get_url module. Also when extracting, on macos the `unarchive` module might fails as it asks for gtar but default macos tar is `bsdtar`. The workaround is to run it as command on macos machines. Signed-off-by: [email protected]
6eaf978
to
c7f3aec
Compare
@sxa that is done. |
Running another VPC at https://ci.adoptium.net/job/VagrantPlaybookCheck/2150/ |
It helps improve
Ant-Contrib
role by replacing wget with get_url module. Also when extracing, on macos theunarchive
module might fails as it asks for gtar but default macos tar isbsdtar
. The workaround is to run it as command on macos machines.Signed-off-by: [email protected]
Checklist