Correcting and/or exempting linter shellcheck code warnings #4254
Conversation
Signed-off-by: Adam Farley <[email protected]>
...because we don't run builds on solaris as part of said checks, so it's a waste of time. Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
adamfarley
changed the title
There was a problem hiding this comment.
Probably ok but will need testing so I'm not going to approve this yet.
Although I will say that this looks overly complex IMHO:
XVFB5=`ps -fu vagrant | grep 'Xvfb :5' | grep -v grep | wc -l`
XVFB5=`ps -fu vagrant | awk '/Xvfb :5/ && !/awk/ {c=c+1} END {print c+0}'`
|
Probably throwing in a comment explaining some of the more complex shell scripting will help. Copilot is your friend for this :-) |
github-actions
bot
added
the
solaris
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
|
Changes blocked. May be related to the webhook failures today. This task is paused until that is resolved and the checks can rerun on the latest commit. |
Merge conflict... |
resolve_linter_errors
Resolved. Good spot. :) Will monitor the linter run now. We should be good to merge if that passes. |
adamfarley
requested review from
karianna
and removed request for
steelhead31
|
Note: The only "PR check" failures are the ones I skipped (windows/linux/mac builds). |
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
adamfarley
requested review from
andrew-m-leonard and
steelhead31
and removed request for
andrew-m-leonard,
karianna and
steelhead31
github-project-automation
bot
moved this from In Progress
to Done
in 2025 Adoptium Plan
|
Thank you @sxa and @steelhead31 😎 |
5 participants
Also includes a change to the PR build pipeline workflow to exempt the solaris files as we don't test solaris in those builds.
Status
Linter check - passed.
Test run: Looks like this branch needs to be hard-coded in the job. Created a copy of the job and giving it a shot:
https://ci.adoptium.net/job/adam_farley_solaris_test_job_copy/