BetterDisplay support #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whitelist_rules configuration key has been renamed to only_rules on version 0.41.0 (Nov 8, 2020) https://github.com/realm/SwiftLint/releases/tag/0.41.0
If the audio device fails to set volume or mute: - Check if the device is a possible display (connected via HDMI or DisplayPort) - Check if BetterDisplay app is installed - Execute the desired volume/mute option in BetterDisplay Why: Some display audio devices (if not all) can't be controlled directly with macOS volume options or MultiSoundChanger. BetterDisplay makes this possible. When controlling the volume of a multi-output device BetterDisplay magic is not applied, so this implementation solves this scenario. waydabber/BetterDisplay#2194
Author
|
By the way maybe you can bump the version number since your fork has so many changes it deserves it. Possibly v1.2 is a good option. |
BetterDisplay CLI commands hang a while and file if the application is not running. Using DistributedNotificationCenter instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the audio device fails to set volume or mute:
Why:
Some display audio devices (if not all) can't be controlled directly with macOS volume options or MultiSoundChanger. BetterDisplay makes this possible.
When controlling the volume of a multi-output device BetterDisplay magic is not applied, so this implementation solves this scenario.
waydabber/BetterDisplay#2194
Includes:
The whitelist_rules configuration key has been renamed to only_rules on version 0.41.0 (Nov 8, 2020) https://github.com/realm/SwiftLint/releases/tag/0.41.0