(Issue #51) Disabled prefer-immutable-types #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielnixon ready for re-review. |
danielnixon
reviewed
Jan 11, 2024
| }, | ||
| ], | ||
| curly: ["error"], | ||
| "functional/prefer-immutable-types": "off", |
There was a problem hiding this comment.
It's not clear, but this is actually a generated file. index.ts is the one to update. I forget why we were forced (?) to commit the generated js. It certainly needs to part of the bundle that becomes published npm package but maybe we can remove from git to reduce confusion.
There was a problem hiding this comment.
I've updated .ts instead and rebuilt the .js files. How is this package published?
danielnixon
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.