Skip to content

Conversation

Patrick2052
Copy link

Changes

Added a list comprehension with string strip to comma separated list arguments.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've added a new changelog entry (in CHANGES.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/sqlacodegen/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@Patrick2052 Patrick2052 changed the title Comma seperated list args to handle spaces Comma seperated list args to handle spaces around the comma Jul 4, 2025
@coveralls
Copy link

coveralls commented Jul 4, 2025

Coverage Status

coverage: 97.671%. remained the same
when pulling 2ded2f2 on Patrick2052:cli-schemas-arg-spaces
into 4d9459f on agronholm:master.

@sheinbergon
Copy link
Collaborator

@Patrick2052 thank you for your contribution. Please clarify what issue you're trying to in the OR description, and add a test to cover it

@sheinbergon sheinbergon force-pushed the cli-schemas-arg-spaces branch from cc96496 to 2ded2f2 Compare August 10, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants