Devex: Modify tests to avoid additional files in core repo #6977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6977 +/- ##
===========================================
+ Coverage 27.16% 79.28% +52.12%
===========================================
Files 566 566
Lines 43807 43807
===========================================
+ Hits 11896 34726 +22830
+ Misses 31911 9081 -22830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GeigerJ2
force-pushed
the
tests/no-extra-repo-files
branch
from
fe98dae to
d76ba31
Compare
Fixing it properly, e.g., by adding a `target_dir` parameter, would require adding it throughout the call stack (`_export_yaml`, `Data.export`, `Data._exportcontent`, `data_export`). Maybe do later on.
GeigerJ2
force-pushed
the
tests/no-extra-repo-files
branch
from
d76ba31 to
e893486
Compare
GeigerJ2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: @danielhollas, with the two commits, when I run the test suite through, I get no additional files. You have anything else to add?