Skip to content

Conversation

Cycloctane
Copy link
Member

What do these changes do?

Some configuration flags are only available in AppRunner. This pr makes them also configurable in run_app().

Are there changes in behavior for the user?

Users can now set more configuration options in run_app() to serve aiohttp web application without creating custom AppRunner instances.

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e260b15) to head (04a7f2f).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11633   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         127      127           
  Lines       43448    43449    +1     
  Branches     2326     2326           
=======================================
+ Hits        42903    42904    +1     
  Misses        389      389           
  Partials      156      156           
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.69% <100.00%> (-0.01%) ⬇️
OS-macOS 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.10.18 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.34% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.94% <100.00%> (-0.01%) ⬇️
Py-3.13.7 98.20% <100.00%> (-0.01%) ⬇️
Py-3.14.0 98.16% <100.00%> (+<0.01%) ⬆️
Py-3.14.0t 97.21% <100.00%> (-0.01%) ⬇️
Py-pypy3.10.16-7.3.19 94.92% <100.00%> (-1.46%) ⬇️
VM-macos 97.58% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 11, 2025

CodSpeed Performance Report

Merging #11633 will not alter performance

Comparing Cycloctane:run_app-parameters (04a7f2f) with master (6b5d8e7)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on master (1f2ef24) during the generation of this report, so 6b5d8e7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 11, 2025
@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Oct 14, 2025
@Dreamsorcerer Dreamsorcerer merged commit b1bd65d into aio-libs:master Oct 14, 2025
42 of 43 checks passed
Copy link
Contributor

patchback bot commented Oct 14, 2025

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b1bd65d on top of patchback/backports/3.13/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633

Backporting merged PR #11633 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633 upstream/3.13
  4. Now, cherry-pick PR Make AppRunner's configuration options available in run_app() #11633 contents into that branch:
    $ git cherry-pick -x b1bd65dbd191b318325c4b87d626bb5d7967cda7
    If it'll yell at you with something like fatal: Commit b1bd65dbd191b318325c4b87d626bb5d7967cda7 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x b1bd65dbd191b318325c4b87d626bb5d7967cda7
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Make AppRunner's configuration options available in run_app() #11633 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Oct 14, 2025

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b1bd65d on top of patchback/backports/3.14/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633

Backporting merged PR #11633 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.14/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633 upstream/3.14
  4. Now, cherry-pick PR Make AppRunner's configuration options available in run_app() #11633 contents into that branch:
    $ git cherry-pick -x b1bd65dbd191b318325c4b87d626bb5d7967cda7
    If it'll yell at you with something like fatal: Commit b1bd65dbd191b318325c4b87d626bb5d7967cda7 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x b1bd65dbd191b318325c4b87d626bb5d7967cda7
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Make AppRunner's configuration options available in run_app() #11633 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.14/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Cycloctane added a commit to Cycloctane/aiohttp that referenced this pull request Oct 14, 2025
Cycloctane added a commit to Cycloctane/aiohttp that referenced this pull request Oct 14, 2025
Dreamsorcerer pushed a commit that referenced this pull request Oct 14, 2025
…ions available in run_app() (#11653)

(cherry picked from commit b1bd65d)
Dreamsorcerer pushed a commit that referenced this pull request Oct 14, 2025
…ions available in run_app() (#11652)

(cherry picked from commit b1bd65d)
@Cycloctane Cycloctane deleted the run_app-parameters branch October 19, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants