document navigation, ad and player-updated hooks #1312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- purge getVideoInfo as data structure is outdated + currently impossible ajayyy#1257 - remove additional regex check on getChannelID
- add pageType to shortcut videoID lookup when looking at channel/ browse/ search/ shorts/ watch - removed unnecessary document clones - reset videoInfo and channelInfo to empty objects instead - use onInvidious to only signify if a page is on invidious - hook into playerClient for reliable isLive/ isPremiere info
mchangrh
changed the title
mchangrh
added a commit
to mchangrh/SponsorBlock
that referenced
this pull request
Jul 29, 2022
1 task
ajayyy
pushed a commit
to mchangrh/SponsorBlock
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
blocked by #1258 because of videoInfo base
closes #311
closes #1278
onInvidousandonMobileYoutubewere kept since they didn't offer any shortcuts and the longer lookup decreased readability