-
Notifications
You must be signed in to change notification settings - Fork 57
chore: build-essentials => build-essential #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build-essentials => build-essential #337
Conversation
WalkthroughAdjusted Debian package name in install script from "build-essentials" to "build-essential", preserving dpkg-based detection, accumulation of missing tools, and apt-get installation flow (using sudo when available). No other behavioral or public-interface changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
script/install_dev_dependencies.sh (3)
14-24: Optional: drop redundant make in Debian deps.build-essential already pulls in make; you can remove the explicit make entry to reduce noise (safe either way).
debian_deps=( - "make" "build-essential" "direnv" "unzip" "wget" "curl" "npm" "jq" "coreutils" )
94-97: Harden Debian package detection and silence output.
dpkg -l "$dep"can return 0 for non-installed but known packages (e.g., rc state) and is noisy. Usedpkg -swith redirection.- if ! dpkg -l "$dep" ; then + if ! dpkg -s "$dep" >/dev/null 2>&1 ; then tools="$tools $dep" status="(not installed)" fi
86-116: Fail fast on non-Debian Linux instead of silently continuing.If
dpkgis absent, the script does nothing and exits 0. Emit a clear message and non-zero exit.elif [[ "$OSTYPE" == "linux-gnu"* ]]; then if is_command dpkg; then echo "Detected Debian based system" tools= # ... - fi + else + echo "Detected Linux but not a Debian-based system (dpkg not found). Please install dependencies manually." >&2 + exit 1 + fi
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
script/install_dev_dependencies.sh(1 hunks)
🔇 Additional comments (1)
script/install_dev_dependencies.sh (1)
16-16: Correct package rename to build-essential.LGTM; this fixes the Debian meta-package name.
4a777cd to
bf73062
Compare
|
Rebased against latest changes to main. |
build-essentials=>build-essential