Skip to content

fix: a better way to use the useRef hook in examples #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: a better way to use the useRef hook in examples #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/AsNavFor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ function AsNavFor() {
let sliderRef2 = useRef(null);

useEffect(() => {
setNav1(sliderRef1);
setNav2(sliderRef2);
setNav1(sliderRef1.current);
setNav2(sliderRef2.current);
}, []);
return (
<div className="slider-container">
<h2>Slider Syncing (AsNavFor)</h2>
<h4>First Slider</h4>
<Slider asNavFor={nav2} ref={slider => (sliderRef1 = slider)}>
<Slider asNavFor={nav2} ref={sliderRef1}>
<div>
<h3>1</h3>
</div>
Expand All @@ -38,7 +38,7 @@ function AsNavFor() {
<h4>Second Slider</h4>
<Slider
asNavFor={nav1}
ref={slider => (sliderRef2 = slider)}
ref={sliderRef2}
slidesToShow={3}
swipeToSlide={true}
focusOnSelect={true}
Expand Down
6 changes: 3 additions & 3 deletions examples/AutoPlayMethods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import Slider from "react-slick";
function AutoPlayMethods() {
let sliderRef = useRef(null);
const play = () => {
sliderRef.slickPlay();
sliderRef.current?.slickPlay();
};
const pause = () => {
sliderRef.slickPause();
sliderRef.current?.slickPause();
};

const settings = {
Expand All @@ -21,7 +21,7 @@ function AutoPlayMethods() {
return (
<div className="slider-container">
<h2>Auto Play {"&"} Pause with buttons</h2>
<Slider ref={slider => (sliderRef = slider)} {...settings}>
<Slider ref={sliderRef} {...settings}>
<div>
<h3>1</h3>
</div>
Expand Down
11 changes: 3 additions & 8 deletions examples/PreviousNextMethods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import Slider from "react-slick";
function PreviousNextMethods() {
let sliderRef = useRef(null);
const next = () => {
sliderRef.slickNext();
sliderRef.current?.slickNext();
};
const previous = () => {
sliderRef.slickPrev();
sliderRef.current?.slickPrev();
};
const settings = {
dots: true,
Expand All @@ -18,12 +18,7 @@ function PreviousNextMethods() {
};
return (
<div className="slider-container">
<Slider
ref={slider => {
sliderRef = slider;
}}
{...settings}
>
<Slider ref={sliderRef} {...settings}>
<div key={1}>
<h3>1</h3>
</div>
Expand Down
9 changes: 2 additions & 7 deletions examples/SlickGoTo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,13 @@ function SlickGoTo() {
<div className="slider-container">
<p>Total updates: {updateCount} </p>
<input
onChange={e => sliderRef.slickGoTo(e.target.value)}
onChange={e => sliderRef.current?.slickGoTo(e.target.value)}
value={slideIndex}
type="range"
min={0}
max={3}
/>
<Slider
ref={slider => {
sliderRef = slider;
}}
{...settings}
>
<Slider ref={sliderRef} {...settings}>
<div>
<img src={baseUrl + "/abstract01.jpg"} />
</div>
Expand Down