Skip to content

Conversation

@harshithb3304
Copy link
Contributor

No description provided.

@notshivansh notshivansh requested a review from Copilot September 23, 2025 12:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive Deployment Configuration feature that allows users to manage environment variables for different deployments through both backend and frontend interfaces.

  • Adds backend data models and DAO layer for deployment configurations with environment variable management
  • Implements RESTful API endpoints for CRUD operations on deployment configs and environment variables
  • Creates a full-featured React UI for managing deployment configurations with modals for adding, editing, and deleting environment variables

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TestingEndpoints.java Adds duplicate TAGS case in switch statement
DeploymentConfig.java New DTO class for deployment configuration with nested EnvVariable class
DeploymentConfigDao.java New DAO class with methods for deployment config and environment variable operations
App.js Adds routing for deployment configs page
SettingsLeftNav.jsx Adds navigation item for deployment configs
api.js Frontend API client for deployment config operations
DeploymentConfigs.jsx Main React component for deployment configuration management UI
struts.xml Defines action mappings for all deployment config API endpoints
DeploymentConfigAction.java Action class implementing all deployment config operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

import com.akto.dto.ApiInfo.ApiInfoKey;
import com.akto.dto.CollectionConditions.MethodCondition;
import com.akto.dto.testing.TagsTestingEndpoints;
import com.akto.dto.testing.TagsTestingEndpoints;
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate import statement for TagsTestingEndpoints. This import already exists on line 7.

Suggested change
import com.akto.dto.testing.TagsTestingEndpoints;

Copilot uses AI. Check for mistakes.
Comment on lines 91 to 94
case TAGS:
String q = (data != null) ? data.getString("query") : null;
condition = new TagsTestingEndpoints(operator, q);
break;
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate case for TAGS enum value. This exact case block already exists above with identical logic, making this code unreachable.

Suggested change
case TAGS:
String q = (data != null) ? data.getString("query") : null;
condition = new TagsTestingEndpoints(operator, q);
break;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants