Skip to content

Conversation

@changluyi
Copy link
Contributor

@changluyi changluyi commented Oct 13, 2025

Summary by CodeRabbit

  • Documentation
    • Clarified ALB + MetalLB environments and introduced "Rapid Failover" with improved failover timing (≈40s → ~10s).
    • Expanded health-check behavior and activation methods to reference ALB + MetalLB and consistent port/probe usage (8080).
    • Updated activation and legacy examples with environment-scoped names, namespaces, reduced replicas, and revised container/image naming.
    • Kept uninstall path as Marketplace → Cluster Plugins → Endpoint Health Checker → Uninstall.

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Walkthrough

Documentation updated to scope Endpoint Health Checker behavior to ALB + MetalLB environments, add a Rapid Failover concept with quantified timing (40s → 10s), and replace activation/uninstallation examples with environment-scoped YAML (namespaces, names, labels, replicas, container names/images, and ports/probes standardized to 8080).

Changes

Cohort / File(s) Summary
Docs: Endpoint Health Checker (ALB + MetalLB focus)
docs/en/configure/networking/functions/endpoint_health_checker.mdx
Revised overview and key features to reference ALB + MetalLB; added Rapid Failover and performance numbers (40s → 10s); updated activation YAMLs (namespace cpaas-system, names, labels, replicas → 3, container names/images, containerPort → 8080, liveness/readiness probes → 8080) for standard and legacy examples; simplified install/uninstall instructions.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant ALB as ALB
  participant MetalLB as MetalLB
  participant EHC as Endpoint Health Checker
  participant Pod as Pod (alb-pod / alb-pod-legacy)
  participant Kubelet as Kubelet

  rect rgb(235,245,255)
    ALB->>EHC: Route traffic / probe endpoints
    MetalLB->>EHC: Route traffic / probe endpoints
    EHC->>Pod: Active health checks (TCP/HTTP on 8080)
    Pod-->>EHC: Health OK / FAIL
  end

  rect rgb(245,255,235)
    alt Failure detected
      EHC->>ALB: Update endpoint/remove failed node
      EHC->>MetalLB: Update endpoint/remove failed node
      ALB-->>Traffic: Rapid failover (~10s)
      MetalLB-->>Traffic: Rapid failover (~10s)
    else No failure
      ALB-->>Traffic: Normal routing
      MetalLB-->>Traffic: Normal routing
    end
  end

  rect rgb(255,245,235)
    Note over Kubelet,EHC: Legacy kubelet-only detection (previous) ≈ 40s
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit checks each endpoint near,
ALB and MetalLB lend an ear.
From forty seconds down to ten,
Pods switch faster—let’s hop again.
Ports at 8080, labels true,
Docs refreshed—hopping through.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly indicates that the pull request refactors documentation for the endpoint health checker with ALB usage, matching a significant part of the changeset while remaining concise and focused on the docs.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 816a189 and 5b14172.

📒 Files selected for processing (1)
  • docs/en/configure/networking/functions/endpoint_health_checker.mdx (5 hunks)
🔇 Additional comments (1)
docs/en/configure/networking/functions/endpoint_health_checker.mdx (1)

16-17: Failover timing clarity looks good

Thanks for aligning both sections on the 10 s failover figure—this resolves the previous inconsistency cleanly.

Also applies to: 59-60


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fca8a0c and 816a189.

📒 Files selected for processing (1)
  • docs/en/configure/networking/functions/endpoint_health_checker.mdx (4 hunks)

@changluyi changluyi force-pushed the change_to_alb_feature branch from 816a189 to 5b14172 Compare October 13, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant