Skip to content

Added stop and trailing stop (limit) order templates with validation #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added stop and trailing stop (limit) order templates with validation #322

wants to merge 2 commits into from

Conversation

pssolanki111
Copy link
Contributor

  • equity stop
  • equity stop limit
  • equity trailing stop
  • equity trailing stop limit
  • Basic validation in the templates.
  • relevant docs changes

swickenburg
swickenburg reviewed Jan 12, 2023
View reviewed changes
tda/orders/equities.py
raise ValueError('When using percent, trailing offset must be >=1 and <=99')

return (OrderBuilder()
.set_order_type(OrderType.TRAILING_STOP)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.set_order_type(OrderType.TRAILING_STOP)
.set_order_type(OrderType.TRAILING_STOP_LIMIT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@swickenburg swickenburg swickenburg left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pssolanki111 @swickenburg