add async sql #335
Open
add async sql #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crimson-gao
reviewed
Sep 10, 2025
| :return: string, query progress | ||
| """ | ||
| meta = self.get_meta() |
There was a problem hiding this comment.
这个可以优化下，用一个 common func，比如 get_or_default 这样更清晰一点
crimson-gao
reviewed
Sep 10, 2025
| request = GetProjectLogsRequest(project, sql, power_sql) | ||
| return self.get_project_logs(request) | ||
|
|
||
| def submit_async_sql(self, request): |
There was a problem hiding this comment.
from .util import require_python3
这里要加上在函数上面
@require_python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.