Skip to content

Add ability to capture failed test outut for Xunit #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ability to capture failed test outut for Xunit #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Allure.Xunit/AllureXunitConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ internal class AllureXunitConfiguration : AllureConfiguration
{
public string XunitRunnerReporter { get; set; } = "auto";

public bool CaptureFailedTestOutput { get; set; } = false;

[JsonConstructor]
protected AllureXunitConfiguration(
string? title,
Expand All @@ -31,8 +33,8 @@ static readonly Lazy<AllureXunitConfiguration> currentConfig
= new(ParseCurrentConfig);

static AllureXunitConfiguration ParseCurrentConfig() => JObject.Parse(
AllureLifecycle.Instance.JsonConfiguration
)["allure"]?.ToObject<AllureXunitConfiguration>()
?? new AllureXunitConfiguration(null, null, null);
AllureLifecycle.Instance.JsonConfiguration
)["allure"]?.ToObject<AllureXunitConfiguration>()
?? new AllureXunitConfiguration(null, null, null);
}
}
}
19 changes: 12 additions & 7 deletions Allure.Xunit/AllureXunitHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,21 @@ internal static void StartAllureTestCase(
testResult ?? CreateTestResultByTest(test)
);

internal static void ApplyTestFailure(IFailureInformation failure)
internal static void ApplyTestFailure(ITestFailed failure)
{
var trace = string.Join("\n", failure.StackTraces);
var message = string.Join("\n", failure.Messages);

if (AllureXunitConfiguration.CurrentConfig.CaptureFailedTestOutput)
{
message = string.Concat(message, "\n", failure.Output);
}

var status = failure.ExceptionTypes.Any(
exceptionType => !exceptionType.StartsWith("Xunit.Sdk.")
) ? Status.broken : Status.failed;
)
? Status.broken
: Status.failed;

AllureLifecycle.Instance.UpdateTestCase(testResult =>
{
Expand Down Expand Up @@ -93,10 +101,7 @@ object[] arguments
}
).ToList();

AllureLifecycle.Instance.UpdateTestCase(testResult =>
{
testResult.parameters = parametersList;
});
AllureLifecycle.Instance.UpdateTestCase(testResult => { testResult.parameters = parametersList; });
}

internal static void ReportCurrentTestCase()
Expand Down Expand Up @@ -174,7 +179,7 @@ static void AddDistinct(

foreach (var value in values)
{
labels.Add(new Label {name = labelName, value = value});
labels.Add(new Label { name = labelName, value = value });
}
}

Expand Down