-
Notifications
You must be signed in to change notification settings - Fork 67
Support for Reqnroll v3 (fixes #580) #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi, @egorshulga Thank you for a nice PR! May I please ask you to extract the workaround part into a separate PR? We can then release a version that works correctly with Reqnroll 2.4.1 for those who are not yet ready to upgrade to Reqnroll 3. |
@delatrie Hm, I am not sure these fixes can be backported 🤔 Reqnroll v3 changed the order and the amount of issued events (they fixed some logical inconsistencies - exactly what the workaround were targeting - when some events were not issued in some edge cases). This PR tries to identify these workarounds and only deletes them (the code does not work anymore in their presence). I am saying that because our main codebase is still on v2.12.1 - and it works (I then assume that all these workarounds are still needed). I will try now locally to debug their removal in the setup that targets v2.12.1 - but I cannot be sure it will work |
I believe they did this in 2.4.1, the latest v2 version they've released. From the release notes:
And there are definitely some problems with Allure.Reqnroll 2.12.1 and Reqnroll 2.4.1, as when I run tests from
For example, some attachment tests are missing: ![]() With Reqnroll 2.3.0, there are five of them: ![]() |
I am checking the project
On branch of this PR (v3.0.0) the amount of files is back to 66 ✅ Indeed, if make the project ⚠ The not-so-good thing is that on v2.4.1 all tests from |
On Reqnroll v2.4.1, no code cherry-picked from this branch (v3.0.0) - For our project that would be pretty straightforward to upgrade to v3.0.0 (our tests already worked when I apply locally built binaries from this branch). The number of attachments seems also to be fixed. Should we invest more time into debugging v2.4.1, or just recommend to others to upgrade directly to v3.0.0? |
@delatrie please let me know of the steps that we should do here |
@egorshulga Sure. I've just discovered some flakiness with Allure.Reqnroll that I need to investigate. I will post back as soon as I get some more details. |
Any news on this? Could we help in getting things working? |
Context
Reqnroll has released a new major version - v3 - https://github.com/reqnroll/Reqnroll/blob/main/CHANGELOG.md#v300---2025-08-21.
The release brings some breaking changes. This leads to the need of the following amendments to the Allure-Reqnroll plugin:
async
versions now should be used instead.InitializeTestRunner()
is gone from the Reqnroll API.That is my first contribution to this codebase, so I hope I do not break conventions and best practices.
All unit and integration tests in Allure repo are made green - I also have a setup against our project's e2e tests ready for debugging. Let me know what you think and if any changes you would see necessary.
Checklist