Remove environment from rake task #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We suspect this is causing the Rake task to be eager loaded on boot, and as the Rake task requires a script that requires dev/test gems, this is causing the app to choke on boot. I’ve also had to add an ignore rule for this file, as Rubocop’s Rails rules require `:environment` to be included.
These do not need the Rails environment either, and will mean they run faster too.
pezholio
force-pushed
the
remove-environment-from-rake-task
branch
from
b1ef3c3 to
5ae80b4
Compare
|
I've added an issue to Rubocop to point out that this might be an issue for some folks rubocop/rubocop-rails#1550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement for
:environmentto be loaded for some tasks that do not use the Rails environment. We initially suspected this to be the cause of our deployment woes, but this was a bit of a red herring. However, I think it's still worth doing because it will mean the tasks come up a bit quicker.