vendor._gowin: use braces around net names in SDC #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gowin's SDC parser doesn't like quotes, so use braces instead. This is a follow-up to PR amaranth-lang#1501, merged as 0f27429. That PR just missed this one last use of tcl_quote.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 44 44
Lines 11402 11402
Branches 2224 2224
=======================================
Hits 10403 10403
Misses 836 836
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gowin's SDC parser doesn't like quotes, so use braces instead.
This is a follow-up to PR #1501, merged as 0f27429. That PR just missed this one last use of
tcl_quote.Actually using signal constraints is somewhat fragile, as Gowin's tools don't seem to be listening to the
(* keep = "true" *)attributes, but at least now there's no syntax error in the SDC files.