Add xrt_test option for vf concurrency test #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlaccabu
force-pushed
the
vf_test
branch
3 times, most recently
from
7274781 to
0f720e8
Compare
xdavidz
requested changes
Sep 10, 2025
There was a problem hiding this comment.
see https://github.com/amd/xdna-driver/blob/main/test/shim_test/multi_threads.h#L39
which can catch test failures and automatically return 0 for all pass and non-zero for 1 or more test failed.
I think the current thread join doesn't check any test faliures?
hlaccabu
force-pushed
the
vf_test
branch
2 times, most recently
from
e674d73 to
3a6b999
Compare
Signed-off-by: Hayden Laccabue <[email protected]>
xdavidz
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.