Skip to content

Conversation

aktondak
Copy link
Contributor

@aktondak aktondak commented Sep 11, 2025

This PR updates the XRT submodule to latest. There are following changes in this PR

  1. Adds shim code to query archive path from installed driver path (XRT : [XRT-SMI] Archive migration  Xilinx/XRT#9213)
  2. Edits shim code to consume watch mode flag passed down from xrt-smi for event tracing and firmware logging. (XRT : [XRT-SMI]Watch mode flag propagation to driver Xilinx/XRT#9218)
  3. Updates context health report to get ctx id and PID from driver. (XRT : [XRT-SMI] Context health report update Xilinx/XRT#9221)

maxzhen
maxzhen previously approved these changes Sep 11, 2025
CMake/pkg.cmake Outdated
)

# Install VTD runner archive file
install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/VTD/runner/xrt_smi_strx.a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only for stx, not phx? how about phx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to do it in phases and add phoenix later. But now I think of it, this PR might fail pipeline for xrt-smi validate failure on phoenix.
Let me update this PR to add phoenix archive as well once this PR fails pipeline with expected behavior.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to do it in phases and add phoenix later. But now I think of it, this PR might fail pipeline for xrt-smi validate failure on phoenix. Let me update this PR to add phoenix archive as well once this PR fails pipeline with expected behavior.

Yeah, it may fail. Good if you can also have phx .a file

Signed-off-by: Akshay Tondak <[email protected]>
xdavidz and others added 7 commits September 16, 2025 17:15
…d#733)

- Introduce a single DPT-based infrastructure for firmware
  debug/profile/trace across current and future devices. Remove legacy
  event-trace/DRAM logging to cut redundancy.
- Improve ring handling by extending 32-bit FW pointers to 64-bit
  in-driver, making wrap and tail tracking robust and transparent
- Enable firmware logging by default at ERROR level. Simplify
  usage via a boolean debugfs node (dump_fw_log) to toggle printing
  to dmesg.
- Provide module params for advanced control (fw_log_level, fw_log_size,
  poll_fw_log).
- Establish common management-DMA helpers for buffer allocation/handling.
  More consolidation to follow.

Signed-off-by: Nishad Saraf <[email protected]>
Fix coverity use after free.

Signed-off-by: Nishad Saraf <[email protected]>
Signed-off-by: advanaik <[email protected]>
Signed-off-by: David Zhang <[email protected]>
Co-authored-by: advanaik <[email protected]>
* VTD submod removal

Signed-off-by: Akshay Tondak <[email protected]>

* subdir removal

Signed-off-by: Akshay Tondak <[email protected]>

---------

Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
@maxzhen maxzhen merged commit cbbfbfd into amd:main Sep 17, 2025
1 check passed
@aktondak aktondak deleted the archive_support branch September 23, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants