shim changes for dump log pr #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: advanaik <[email protected]>
Signed-off-by: David Zhang <[email protected]>
maxzhen
previously approved these changes
Sep 12, 2025
hlaccabu
previously approved these changes
Sep 12, 2025
|
created PR - Xilinx/XRT#9230 with the fix. I will update once the change is merged. Thanks |
|
I'd wait for @xuhz comment on the details of this design. Please hole the merge. |
xuhz
reviewed
Sep 15, 2025
src/shim/hwctx.cpp
Outdated
| hwctx:: | ||
| get_num_uc() const | ||
| { | ||
| return m_col_cnt; |
There was a problem hiding this comment.
num of uc is 2 * m_col_cnt for aie4
log buffer bug fix has been merged in XRT - Xilinx/XRT#9230 |
Signed-off-by: David Zhang <[email protected]>
I would like to use a separate clean PR to fix the xrt submodule. I think the build number of xrt should be fixed too. |
|
retest this please |
hlaccabu
approved these changes
Sep 16, 2025
maxzhen
pushed a commit
that referenced
this pull request
Sep 17, 2025
* XRT, VTD submodule update and shim changes Signed-off-by: Akshay Tondak <[email protected]> * VTD update Signed-off-by: Akshay Tondak <[email protected]> * use last firmware for verbose in-memory log (#739) Signed-off-by: David Zhang <[email protected]> * Unify DPT (Debug/Profile/Trace) firmware debug across generations (#733) - Introduce a single DPT-based infrastructure for firmware debug/profile/trace across current and future devices. Remove legacy event-trace/DRAM logging to cut redundancy. - Improve ring handling by extending 32-bit FW pointers to 64-bit in-driver, making wrap and tail tracking robust and transparent - Enable firmware logging by default at ERROR level. Simplify usage via a boolean debugfs node (dump_fw_log) to toggle printing to dmesg. - Provide module params for advanced control (fw_log_level, fw_log_size, poll_fw_log). - Establish common management-DMA helpers for buffer allocation/handling. More consolidation to follow. Signed-off-by: Nishad Saraf <[email protected]> * Fix coverity use after free (#744) Fix coverity use after free. Signed-off-by: Nishad Saraf <[email protected]> * shim changes for dump log pr (#738) Signed-off-by: advanaik <[email protected]> Signed-off-by: David Zhang <[email protected]> Co-authored-by: advanaik <[email protected]> * VTD submodule removal (#745) * VTD submod removal Signed-off-by: Akshay Tondak <[email protected]> * subdir removal Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> * Report addition Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> Signed-off-by: David Zhang <[email protected]> Signed-off-by: Nishad Saraf <[email protected]> Signed-off-by: advanaik <[email protected]> Co-authored-by: David Zhang <[email protected]> Co-authored-by: Nishad Saraf <[email protected]> Co-authored-by: advanaik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdvaitNaik I merged your PR with rolling back the code. We can use another PR to fix the ~dbg_buffer issue.
discussed with @rbramand-xilinx and created ticket - CR-1249680
rahul will make required changes in xrt