Skip to content

Fixes recursive lock acquisition bug encountered on linux. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixes recursive lock acquisition bug encountered on linux. #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions SNAPLib/DataReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ StdioDataReader::startIo()
//
// Synchronously read data into whatever buffers are ready.
//
AcquireExclusiveLock(&lock);
while (nextBufferForReader != -1) {
// remove from free list
BufferInfo* info = &bufferInfo[nextBufferForReader];
Expand All @@ -601,7 +600,6 @@ StdioDataReader::startIo()
info->nBytesThatMayBeginARead = 0;
info->isEOF = true;
info->state = Full;
ReleaseExclusiveLock(&lock);
return;
}

Expand Down Expand Up @@ -679,7 +677,6 @@ StdioDataReader::startIo()
//fprintf(stderr, "startIo thread %x reset releaseEvent\n", GetCurrentThreadId());
PreventEventWaitersFromProceeding(&releaseEvent);
}
ReleaseExclusiveLock(&lock);
}

void
Expand Down