Modernisation 13 - no redundant use strict

.claude/commands/lint-enforce.md

@@ -0,0 +1,13 @@
+Please follow the following process when I ask you to enfore a new lint rule using /lint-enforce $rule
+
+1. Create and change to a new branch. Ask for the branch name.
+2. Configure the rule to error in biome.json
+3. Run lint (npm run lint). If there are NO errors, goto step 9
+4. If there are no errors goto X
+5. Use biome to SAFELY auto fix (npm run lint -- --fix). If there are errors stop and ask for instruction.
+7. Run the tests (npm test). If there are errors, stop and ask for instruction.
+8. If the rule defaults to error, delete it (See https://biomejs.dev/linter/javascript/rules/ for rule details)
+9. Update the project changelog
+10. Add the changes
+11. Commit the changes
+12. Push the changes

CHANGELOG.md

@@ -16,6 +16,7 @@
 - Add node: protocol prefix to Node.js builtin module imports for clarity
 - Use modern exponentiation operator (**) instead of Math.pow()
 - Replace string concatenation with modern template literals
+- Remove redundant 'use strict' directives as modules are automatically in strict mode
 
 ## v0.10.9
 - Add support for IPv6 urls

biome.json

@@ -20,7 +20,7 @@
         "useLiteralKeys": "off"
       },
       "suspicious": {
-        "noRedundantUseStrict": "off",
+        "noRedundantUseStrict": "error",
         "noAssignInExpressions": "off",
         "noAsyncPromiseExecutor": "off",
         "noDoubleEquals": "off",

examples/receive_generator.js

@@ -1,6 +1,4 @@
 #!/usr/bin/env node
-
-'use strict';
 const co = require('co');
 const amqp = require('amqplib');
 const readline = require('node:readline');

examples/send_generators.js

@@ -1,7 +1,5 @@
 #!/usr/bin/env node
 
-'use strict';
-
 // NB this requires the module 'co':
 //    npm install co
 const co = require('co');

lib/api_args.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 /*
 The channel (promise) and callback APIs have similar signatures, and
 in particular, both need AMQP fields prepared from the same arguments

lib/bitset.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 /**
  * A bitset implementation, after that in java.util.  Yes there
  * already exist such things, but none implement next{Clear|Set}Bit or

lib/callback_model.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 const defs = require('./defs');
 const EventEmitter = require('node:events');
 const BaseChannel = require('./channel').BaseChannel;

lib/channel.js

@@ -1,11 +1,3 @@
-//
-//
-//
-
-// Channel machinery.
-
-'use strict';
-
 const defs = require('./defs');
 const closeMsg = require('./format').closeMessage;
 const inspect = require('./format').inspect;

lib/channel_model.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 const EventEmitter = require('node:events');
 const promisify = require('node:util').promisify;
 const defs = require('./defs');

lib/codec.js

@@ -1,9 +1,4 @@
-//
-//
-//
-
 /*
-
 The AMQP 0-9-1 is a mess when it comes to the types that can be
 encoded on the wire.
 
@@ -48,11 +43,8 @@ except that they appear in content header frames, which include a
 content size, and they carry a set of flags indicating which
 properties are present. This scheme can save ones of bytes per message
 (messages which take a minimum of three frames each to send).
-
 */
 
-'use strict';
-
 const ints = require('buffer-more-ints');
 
 // JavaScript uses only doubles so what I'm testing for is whether

lib/connect.js

@@ -1,11 +1,3 @@
-//
-//
-//
-
-// General-purpose API for glueing everything together.
-
-'use strict';
-
 const URL = require('url-parse');
 const QS = require('node:querystring');
 const Connection = require('./connection').Connection;

lib/connection.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 const defs = require('./defs');
 const constants = defs.constants;
 const frame = require('./frame');

lib/format.js

@@ -1,11 +1,3 @@
-//
-//
-//
-
-// Stringifying various things
-
-'use strict';
-
 const defs = require('./defs');
 const format = require('node:util').format;
 const HEARTBEAT = require('./frame').HEARTBEAT;

lib/frame.js

@@ -1,9 +1,3 @@
-// The river sweeps through
-// Silt and twigs, gravel and leaves
-// Driving the wheel on
-
-'use strict';
-
 const ints = require('buffer-more-ints');
 const defs = require('./defs');
 const constants = defs.constants;

lib/heartbeat.js

@@ -1,7 +1,3 @@
-//
-//
-//
-
 // Heartbeats. In AMQP both clients and servers may expect a heartbeat
 // frame if there is no activity on the connection for a negotiated
 // period of time. If there's no activity for two such intervals, the
@@ -45,8 +41,6 @@
 // %% Yes, I could apply the same 'actually passage of time' thing to
 // %% send as well as to recv.
 
-'use strict';
-
 const EventEmitter = require('node:events');
 
 // Exported so that we can mess with it in tests

lib/mux.js

@@ -1,9 +1,3 @@
-//
-//
-//
-
-'use strict';
-
 // A Mux is an object into which other readable streams may be piped;
 // it then writes 'packets' from the upstreams to the given
 // downstream.

test/bitset.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const claire = require('claire');
 const {BitSet} = require('../lib/bitset');
 

test/callback_api.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const assert = require('node:assert');
 const api = require('../callback_api');
 const util = require('./util');

test/channel.js

@@ -1,7 +1,3 @@
-// Test the channel machinery
-
-'use strict';
-
 const assert = require('node:assert');
 const promisify = require('node:util').promisify;
 const Channel = require('../lib/channel').Channel;

test/channel_api.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const assert = require('node:assert');
 const api = require('../channel_api');
 const util = require('./util');

test/codec.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const codec = require('../lib/codec');
 const defs = require('../lib/defs');
 const assert = require('node:assert');

test/connect.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const connect = require('../lib/connect').connect;
 const credentialsFromUrl = require('../lib/connect').credentialsFromUrl;
 const defs = require('../lib/defs');

test/connection.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const assert = require('node:assert');
 const defs = require('../lib/defs');
 const Connection = require('../lib/connection').Connection;

test/data.js

@@ -1,7 +1,3 @@
-// Property-based testing representations of various things in AMQP
-
-'use strict';
-
 const C = require('claire');
 const forAll = C.forAll;
 const arb = C.data;

test/frame.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const assert = require('node:assert');
 const connection = require('../lib/connection');
 const Frames = connection.Connection;

test/mux.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const assert = require('node:assert');
 const Mux = require('../lib/mux').Mux;
 const PassThrough = require('node:stream').PassThrough;

test/util.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const crypto = require('node:crypto');
 const Connection = require('../lib/connection').Connection;
 const PassThrough = require('node:stream').PassThrough;