-
Notifications
You must be signed in to change notification settings - Fork 1.6k
projects/cn0577: Add build parameters, update IP GUI #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
StancaPop
previously approved these changes
Jul 30, 2025
13 tasks
- projects/cn0577: Added make parameters ADC_RES (the ADC input resolution) and TWOLANES (two-lane mode or one-lane mode). Also fixed the sysid parameters logging - library/axi_ltc2387/axi_ltc2387_if.v: Changed the parameter name RESOLUTION to ADC_RES, as it was redundant Signed-off-by: Iulia Moldovan <[email protected]>
… mode Signed-off-by: Iulia Moldovan <[email protected]>
Signed-off-by: Iulia Moldovan <[email protected]>
8f313fa
to
b4968b4
Compare
Rebased to latest main |
b4968b4
to
381e1ee
Compare
Removed my commit where I deleted the IP GUI parameters, and replaced it with @StancaPop's commit where she updates the parameters. |
AndreiGrozav
reviewed
Sep 1, 2025
Signed-off-by: Stanca Pop <[email protected]>
Signed-off-by: Stanca Pop <[email protected]>
Dinamically set the PULSE_1_WIDTH parameter of the axi_ltc2387 IP, instead of hardcoding it and then overwriting it in software. Signed-off-by: Stanca Pop <[email protected]>
Signed-off-by: Stanca Pop <[email protected]>
Signed-off-by: Stanca Pop <[email protected]>
a4c9a34
to
a6eaa85
Compare
AndreiGrozav
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR Type
PR Checklist