Skip to content

Conversation

gastmaier
Copy link
Contributor

@gastmaier gastmaier commented Aug 27, 2025

PR Description

Consider lines that start with endif, since it may have comments.
Detected by run of #2913
https://github.com/analogdevicesinc/linux/actions/runs/17266053343/job/48998303938?pr=2913

Create deadcode_exceptions file, for API code mostly, to reduce noise from #2909

Demote assert_compiled step, for in case of API code not added yet to the deadcode_exceptions file, still run the next steps, also #2909

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

Consider lines that start with endif, since it may have comments.

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier
Copy link
Contributor Author

@pamolloy your oran branch will fail with

Warning: kernel: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
 525 | dev_dbg(dma->dev, "dma config: src = 0x%llx, dst = 0x%llx\n", desc->src, desc->dest);
 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Warning: kernel: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
 525 | dev_dbg(dma->dev, "dma config: src = 0x%llx, dst = 0x%llx\n", desc->src, desc->dest);
 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Warning: kernel: left shift count >= width of type [-Wshift-count-overflow]
 7 | #define BIT(nr) (UL(1) << (nr))
 | ^~
Warning: kernel: left shift count >= width of type [-Wshift-count-overflow]
 8 | (((~_UL(0)) - (_UL(1) << (l)) + 1) & \
 | ^~
Warning: kernel: right shift count is negative [-Wshift-count-negative]
 9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
 | ^~
Warning: kernel: no previous prototype for 'adrv906x_phc_pll_probe' [-Wmissing-prototypes]
 337 | int adrv906x_phc_pll_probe(struct adrv906x_phc_pll *pll_phc)
 | ^~~~~~~~~~~~~~~~~~~~~~
Warning: kernel: no previous prototype for 'adrv906x_pll_remove' [-Wmissing-prototypes]
 384 | int adrv906x_pll_remove(struct adrv906x_phc_pll *pll_phc)
 | ^~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_adrv906x_soc.c: In function 'adrv906x_ptp_remove':
Error: kernel: void value not ignored as it ought to be
 431 | ret = adrv906x_tod_remove(pdev);
 | ^
drivers/ptp/ptp_adrv906x_soc.c: At top level:
Error: kernel: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)' [-Wincompatible-pointer-types]
 451 | .remove = adrv906x_ptp_remove,
 | ^~~~~~~~~~~~~~~~~~~
Error: Process completed with exit code 1.

Add support for a deadcode_exceptions file that contains a list of files
are allowed to not be compiled. Useful for API code that are seasonally
committed.

Signed-off-by: Jorge Marques <[email protected]>
Allow the step to fail and keep running the CI, effectively now the CI only
prematurely stops if compile_devicetree or compile_kernel steps fails.

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier gastmaier merged commit e00bb4b into main Aug 28, 2025
14 checks passed
@gastmaier gastmaier deleted the ci/update branch August 28, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants