Add dts for AD4000 on cora #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machschmitt
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
mhennerich,
nunojsa and
rbolboac
as code owners
nunojsa
approved these changes
Nov 5, 2025
There was a problem hiding this comment.
Just one small nit... Also if you run git log --oneline --no-merges arch/arm/boot/dts (preferably on an upstream tree) you'll see slightly different style for git subjects in ARM (would be nice if we all start following the same style :)).
But, FWIW, PR accepted
| }; | ||
|
|
||
| &fpga_axi { | ||
|
|
There was a problem hiding this comment.
nit. No need for the blank line
There was a problem hiding this comment.
hold on, I'll fix those.
There was a problem hiding this comment.
fixed. Dropped blank line after &fpga_axi. Updated patch title to be similar to upstream dts title pattern.
There was a problem hiding this comment.
Thanks! Much appreciated 👍
Add device tree for using AD4000 on CoraZ7. Signed-off-by: Marcelo Schmitt <[email protected]>
machschmitt
force-pushed
the
coraz7-ad4000-dts
branch
from
a6ccf70 to
ae0e6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device tree for using AD4000 on CoraZ7.
PR Description
Add a device tree for using AD4000 on CoraZ7. AD4000 eval boards interfaced the SPI host through an FMC connector. Though, there seem to be a new evaluation board for AD4000 that used a PMOD connector.
PR Type
PR Checklist