Draw embedded images only a single time #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedded images were previously drawn once for each character in the embed key, causing issues for semi-transparent images. See issue andymeneely#278. With this commit, the embed image is only drawn for the first character in the embed keys, and a sentinel attribute is used for the remaining characters in the key to draw neither text not an image for them.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded images were previously drawn once for each character
in the embed key, causing issues for semi-transparent images.
See issue #278. With this commit, the embed image is only drawn
for the first character in the embed key, and a sentinel
attribute is used for the remaining characters in the key to
draw neither text not an image for them.