fix: normalize usernames with NFC to dedupe umlaut variants #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PR
Some more infos
In
calcTeamAlignment, the actualTeams set can end up containing "duplicate" entries for the same user when their name includes an umlaut. This happens because JavaScript strings with precomposed (“ä” U+00E4) and decomposed (“a\u0308” + COMBINING DIAERESIS) representations are treated as distinct values by Set. We need to normalize all usernames to NFC before using them as keys so that “Mäster” and “Mäster” collapse to the same string.BEFORE:
You will end up with two users in the set
AFTER:
Only one user. Test in
team-alignment.spec.tsshould clearify