Murisi/patch keys 0.6.1 #146
Open
+262
−1,250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/patch-keys-0.6.1
branch
from
6133b42 to
216bca3
Compare
murisi
force-pushed
the
murisi/patch-keys-0.6.1
branch
from
8bf20b9 to
2c54383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove manual implementations of Rustler encoding/decoding for each data type. Instead, ensure that all types required by Elixir have a Serde derivation. This way, Rustler encoding/decoding based on Serde serializations/deserializations can be done through the
SerdeTermstructure provided by Rustler. Given the reduction in code, this PR should reduce the likelihood of encoding/decoding bugs and enable greater freedom to fix serialisation bugs downstream in theanoma-sdkwithout needing to modifyarm-risc0.