Skip to content

fixes a bug in cisco.nxos.nxos_vlans after return var #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixes a bug in cisco.nxos.nxos_vlans after return var #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad00f86
fixes a bug in cisco.nxos.nxos_vlans after return var
Feb 28, 2025
22eb313
Merge branch 'main' into nxos_vlans_after_regex
heathdbrown Mar 6, 2025
35b70c1
adds changelog fragment
heathdbrown Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/nxos_vlans_after_regex.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- cisco.nxos.nxos_vlans - fix vlans regex pattern that ignores vlans missing a name, even though the vlan has a vn-segment. (https://github.com/ansible-collections/cisco.nxos/pull/938).

Check failure on line 2 in changelogs/fragments/nxos_vlans_after_regex.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[line-length] 

Line too long (187 > 160 characters)
2 changes: 1 addition & 1 deletion plugins/module_utils/network/nxos/facts/vlans/vlans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def normalize_table_data(self, structured, run_cfg_output):
# Sample match lines
# 202\n name Production-Segment-100101\n vn-segment 100101
# 5\n state suspend\n shutdown\n name test-changeme\n vn-segment 942
pattern = r"^{0}\s+\S.*vn-segment".format(v["vlan_id"])
pattern = r"^{0}\s+.*vn-segment".format(v["vlan_id"])
if re.search(pattern, item, flags=re.DOTALL):
vlan["run_cfg"] = item
break
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/modules/network/nxos/fixtures/nxos_vlans/show_running-config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
vlan 1,3-5,8
vlan 3
name test-vlan3
vlan 4
vn-segment 402
vlan 5
shutdown
name test-changeme
Expand Down
Loading