Issue #988: Make l2_interfaces mode: access idempotent
#989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the following: * detects where the mode is access by default and reports it in the facts * it limits operations to interfaces which are configured as layer2 interfaces By augmenting the facts with `mode: access` where it was not previously, the use of `mode: access` becomes idempotent. BREAKING: If an input configuration is supplied that attempts to apply L2 configuration to an interface that is L3 (or doesn't exist), an exception will be raised telling the user that they should use `nxos_interfaces` to first configure the interface for L2. Fixes: ansible-collections#988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following:
By augmenting the facts with
mode: accesswhere it was not previously, the use ofmode: accessbecomes idempotent.BREAKING: If an input configuration is supplied that attempts to apply L2 configuration to an interface that is L3 (or doesn't exist), an exception will be raised telling the user that they should use
nxos_interfacesto first configure the interface for L2.Fixes: #988
ISSUE TYPE
COMPONENT NAME
nxos_l2_interfaces