Skip to content

ini_file: fix adding / replacing a whole section when option is unset #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ini_file: fix adding / replacing a whole section when option is unset #10288

wants to merge 1 commit into from
+246 −66

Conversation

amosyuen
Copy link

@amosyuen amosyuen commented Jun 21, 2025 •
edited by felixfontein
Loading

SUMMARY

Fixes #10287.

Documentation for "option" says "May be omitted if adding/removing a whole section". But adding / replacing a section does not work and instead throws an error.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ini_file

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @jpmens @noseka1
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jun 21, 2025
@amosyuen amosyuen force-pushed the patch-1 branch 2 times, most recently from e9d4c6a to c6bcc3a Compare June 21, 2025 05:35
@amosyuen
Support setting whole section when option is unset
2707ca0 
Docs sound like you can set a section by not setting option, but it didn't work previously, this fixes that.
felixfontein
felixfontein reviewed Jun 21, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is how the feature should work. Basically what you need is a way to specify multiple key/value pairs.

I'm currently not sure whether this feature makes sense at all without a redesign of the module's interface.

@felixfontein felixfontein added feature This issue/PR relates to a feature request and removed bug This issue/PR relates to a bug labels Jun 21, 2025
@russoz russoz changed the title Fixes adding / replacing a whole section when option is unset ini_file: fix adding / replacing a whole section when option is unset Jun 23, 2025
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ini_file unable to add / replace whole section
3 participants
@amosyuen @ansibullbot @felixfontein