-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add dad-timeout feature for nmcli #10844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add dad-timeout feature for nmcli #10844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please note that you have to adjust the unit tests to avoid the failure. Also please note that this is a new feature, so you should add a small test for it as well to the unit tests. Thanks!
@@ -0,0 +1,2 @@ | |||
minor_changes: | |||
- nmcli - add support for duplicate address detection (DAD) timeout configuration via new parameters ``dad_timeout4`` and ``dad_timeout6`` which map to the ``ipv4.dad-timeout`` and ``ipv6.dad-timeout`` NetworkManager properties (https://github.com/ansible-collections/community.general/pull/XXXX). No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- nmcli - add support for duplicate address detection (DAD) timeout configuration via new parameters ``dad_timeout4`` and ``dad_timeout6`` which map to the ``ipv4.dad-timeout`` and ``ipv6.dad-timeout`` NetworkManager properties (https://github.com/ansible-collections/community.general/pull/XXXX). | |
- nmcli - add support for duplicate address detection (DAD) timeout configuration via new parameters ``dad_timeout4`` and ``dad_timeout6`` which map to the ``ipv4.dad-timeout`` and ``ipv6.dad-timeout`` NetworkManager properties (https://github.com/ansible-collections/community.general/issues/10843, https://github.com/ansible-collections/community.general/pull/10844). |
- Maps to the C(ipv4.dad-timeout) NetworkManager property. | ||
- This helps prevent IP address conflicts by detecting duplicate addresses before assignment. | ||
type: int | ||
version_added: 10.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version_added: 10.1.0 | |
version_added: 11.4.0 |
same below
SUMMARY
Add support for setting IPv4 and IPv6 duplicate address detection (DAD) timeout parameters in the community.general.nmcli module. This enables users to configure NetworkManager's
ipv4.dad-timeout
andipv6.dad-timeout
settings directly through Ansible, providing better control over network configuration and preventing IP address conflicts in automated environments.This feature adds two new parameters:
dad_timeout4
: Integer value in milliseconds for IPv4 DAD timeoutdad_timeout6
: Integer value in milliseconds for IPv6 DAD timeoutFixes #10843
ISSUE TYPE
COMPONENT NAME
nmcli
ADDITIONAL INFORMATION
Background:
Duplicate address detection is a critical network safety feature that prevents IP conflicts. The default DAD timeout is -1 (disabled) for IPv4, leaving networks vulnerable to address conflicts. Currently, users must resort to raw nmcli commands or shell modules to set these parameters, breaking Ansible's idempotency model.
Use Cases:
Implementation Details:
dad_timeout4
anddad_timeout6
parameters to module argument specificationipv4.dad-timeout
andipv6.dad-timeout
Example Usage: